Skip to content

[export] Only export as deleted entries explicitly so#4178

Draft
imnasnainaec wants to merge 1 commit intomasterfrom
lift-export-deleted-explicit
Draft

[export] Only export as deleted entries explicitly so#4178
imnasnainaec wants to merge 1 commit intomasterfrom
lift-export-deleted-explicit

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 24, 2026

If a word is removed from the frontier by some unforeseen bug, we don't want that word deleted from the user's FieldWorks project. So this pr will add a guard against that.

Required database update to go with this pr:

  • Add Deleted copies of any words with GUID missing from the Frontier.

Reason: Prior to #4155, merge children were not marked as deleted in the database, so without the database update, this change would result in the children of merges not being deleted in FW, which would undermine the cleanup done in TC.

Side-effect: We cannot distinguish between words that were wrongfully lost from the fronter and words that were deleted (not merged) with the Merge Duplicates tool. So any of the former (which are so far only known to exist in one project), will be cemented as Deleted.

The database update will be easier after #4179 (and it's associated database update) is complete.


This change is Reviewable

@coderabbitai
Copy link

coderabbitai bot commented Feb 24, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch lift-export-deleted-explicit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.52%. Comparing base (5ebd071) to head (e3967c4).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4178       +/-   ##
===========================================
+ Coverage   74.95%   86.52%   +11.57%     
===========================================
  Files         302       56      -246     
  Lines       11090     4846     -6244     
  Branches     1394      604      -790     
===========================================
- Hits         8312     4193     -4119     
+ Misses       2378      511     -1867     
+ Partials      400      142      -258     
Flag Coverage Δ
backend 86.52% <100.00%> (+<0.01%) ⬆️
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant