[export] Only export as deleted entries explicitly so#4178
[export] Only export as deleted entries explicitly so#4178imnasnainaec wants to merge 1 commit intomasterfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4178 +/- ##
===========================================
+ Coverage 74.95% 86.52% +11.57%
===========================================
Files 302 56 -246
Lines 11090 4846 -6244
Branches 1394 604 -790
===========================================
- Hits 8312 4193 -4119
+ Misses 2378 511 -1867
+ Partials 400 142 -258
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
If a word is removed from the frontier by some unforeseen bug, we don't want that word deleted from the user's FieldWorks project. So this pr will add a guard against that.
Required database update to go with this pr:
Reason: Prior to #4155, merge children were not marked as deleted in the database, so without the database update, this change would result in the children of merges not being deleted in FW, which would undermine the cleanup done in TC.
Side-effect: We cannot distinguish between words that were wrongfully lost from the fronter and words that were deleted (not merged) with the Merge Duplicates tool. So any of the former (which are so far only known to exist in one project), will be cemented as Deleted.
The database update will be easier after #4179 (and it's associated database update) is complete.
This change is