Conversation
| s.push(ch); | ||
| } | ||
| } else if ch != '}' { | ||
| s.push(ch); |
There was a problem hiding this comment.
The mustache format check is done elsewhere by regular expression, should we add another case for ch == '\n'?
Collaborator
Author
There was a problem hiding this comment.
I'm not sure what regular expression you're referring to. I can't think of any particular reason to block multi-line {{ }} other than it doesn't appear to currently work in the product.
There was a problem hiding this comment.
That makes sense, you have more context than I do here. The regular expression I'm referring to pulls out the template keys for replacement. I was thinking this could be a good place to throw an error since it's easy to detect multiline mustaches, but we can likely just as easily detect a missing template key in this case.
colinmparker
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.