Skip to content

Remove string continuations#3362

Merged
RobbieTheWagner merged 1 commit intomainfrom
remove-string-continuations
Feb 13, 2026
Merged

Remove string continuations#3362
RobbieTheWagner merged 1 commit intomainfrom
remove-string-continuations

Conversation

@RobbieTheWagner
Copy link
Member

@RobbieTheWagner RobbieTheWagner commented Feb 13, 2026

Summary by CodeRabbit

  • Refactor
    • Internal code improvements to string assembly patterns with no impact on functionality or user experience.

@vercel
Copy link

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
shepherd-docs Ready Ready Preview, Comment Feb 13, 2026 3:39pm
shepherd-landing Ready Ready Preview, Comment Feb 13, 2026 3:39pm

Request Review

@coderabbitai
Copy link

coderabbitai bot commented Feb 13, 2026

📝 Walkthrough

Walkthrough

The overlay-path.ts utility file is refactored to replace multi-line template string segments with explicit concatenation operators, restructuring how the SVG path string is assembled without altering generated output.

Changes

Cohort / File(s) Summary
String Concatenation Refactoring
shepherd.js/src/utils/overlay-path.ts
Rewrites overlay path string generation from backslash-separated template literals to single-line concatenation with + operators; no functional or semantic changes to produced SVG paths.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A path through the code, made straight and bright,
Concatenation flows left and right,
Same SVG story, but cleaner style,
The overlay grins with a formatting smile! ✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove string continuations' accurately reflects the main change: refactoring string assembly by removing backslash line continuations in favor of + operator concatenation.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-string-continuations

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
shepherd.js/src/utils/overlay-path.ts (1)

53-61: Nit: unnecessary template literal on line 60.

`${openings}` can be simplified to just openings since it's already a string being concatenated with +.

♻️ Suggested simplification
   return (
     `M${w},${h}` +
     `H0` +
     `V0` +
     `H${w}` +
     `V${h}` +
     `Z` +
-    `${openings}`
+    openings
   ).replace(/\s/g, '');

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@qltysh
Copy link

qltysh bot commented Feb 13, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
shepherd.js/src/utils/overlay-path.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@RobbieTheWagner RobbieTheWagner merged commit a019ad5 into main Feb 13, 2026
10 checks passed
@RobbieTheWagner RobbieTheWagner deleted the remove-string-continuations branch February 13, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant