Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

readme fix: Shipment.all – pass parameters as a hash#152

Open
Jonathan-Jacob wants to merge 1 commit intoshipcloud:masterfrom
Jonathan-Jacob:update-docs
Open

readme fix: Shipment.all – pass parameters as a hash#152
Jonathan-Jacob wants to merge 1 commit intoshipcloud:masterfrom
Jonathan-Jacob:update-docs

Conversation

@Jonathan-Jacob
Copy link

Replaced this

Shipcloud::Shipment.all(
  carrier: 'ups',
  per_page: 25,
  page: 2
)

with this

Shipcloud::Shipment.all({
  carrier: 'ups',
  per_page: 25,
  page: 2
})

since otherwise you will get an ArgumentError

@Jonathan-Jacob
Copy link
Author

Failed checks should be irrelevant since this is only a PR for a README change

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant