Skip to content

upgrade garmin fit sdk profile version 21.194.0#25

Open
shaonianche wants to merge 1 commit intomainfrom
21.194.0
Open

upgrade garmin fit sdk profile version 21.194.0#25
shaonianche wants to merge 1 commit intomainfrom
21.194.0

Conversation

@shaonianche
Copy link
Owner

Close: #24

Signed-off-by: friendsa <github@duanfei.org>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @shaonianche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Garmin FIT SDK version constant within the project. This change ensures that the tool is aligned with the latest FIT profile definitions, improving compatibility and addressing a reported issue.

Highlights

  • SDK Version Update: The Garmin FIT SDK version has been upgraded from '21.188.0' to '21.194.0'.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • fit_tool/init.py
    • Updated the SDK_VERSION constant to '21.194.0'.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Garmin FIT SDK version from 21.188.0 to 21.194.0. While the version constant is updated correctly, the corresponding profile file, Profile_21.194.0.xlsx, appears to be missing. This file is required by the profile generation script and is checked for in the tests, so its absence will likely cause the build to fail. Please add the new profile file to the pull request. Additionally, it would be good practice to document this dependency upgrade in CHANGELOG.md.

@@ -1,3 +1,3 @@
PROTOCOL_VERSION = '2.4'
SDK_VERSION = '21.188.0'
SDK_VERSION = '21.194.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This version update requires the corresponding profile file Profile_21.194.0.xlsx to be present in the fit_tool/gen/ directory. Without this file, the profile loading mechanism in fit_tool/gen/profile.py and the test in fit_tool/tests/test_profile.py will fail. Please add the required file to this pull request to ensure the project remains buildable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade garmin fit sdk profile version 21.194.0

1 participant