Conversation
…ow guards - Remove ModeRPC and ModeIndexer (identical aliases for ModeFull/ModeArchive) - Export DefaultSnapshotInterval constant for controller use - Add SnapshotGenerationOverrides() helper for snapshot-producing nodes - Replace TOML round-trip in ApplyOverrides with direct Registry+reflection, unifying the string-to-typed-value path with ResolveEnv - Remove setNestedKey, coerceToType, splitDottedKey (no longer needed) - Add overflow guards in setReflectValue for narrower int/uint types - Add comprehensive ApplyOverrides tests for every type path and error case
bdchatham
force-pushed
the
refactor/cleanup-modes-overrides
branch
from
462466d to
df21a62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModeRPCandModeIndexer— they were identical aliases forModeFull/ModeArchivewith zero differentiationDefaultSnapshotIntervalconstant and addSnapshotGenerationOverrides()helper so the controller does not need to duplicate snapshot config knowledgeApplyOverrideswith direct Registry key lookup +setFieldByPathreflection — the same code pathResolveEnvuses, eliminating ~100 lines (setNestedKey,coerceToType,splitDottedKey)setReflectValuefor narrower integer types (int32,uint16,uint32) that were previously silently truncatedApplyOverridestests covering every type path (bool, uint, float, Duration, int64) and error cases (unknown key, invalid values, overflow)Test plan