chore(evmrpc): expose eth_blobBaseFee on eth RPC surface#3080
chore(evmrpc): expose eth_blobBaseFee on eth RPC surface#3080mojtaba-esk wants to merge 6 commits intomainfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3080 +/- ##
=======================================
Coverage 58.39% 58.39%
=======================================
Files 2088 2088
Lines 172108 172067 -41
=======================================
- Hits 100506 100487 -19
+ Misses 62656 62635 -21
+ Partials 8946 8945 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
masih
left a comment
There was a problem hiding this comment.
The integration_test/evm_module/rpc_io_test/testdata/eth_blobBaseFee/get-current-blobfee.iox needs updating too right?
Separately, we have eip4844.CalcBlobFee that is used in a few places. Checking that you have seen it and there is a good reason not to use it here?
evmrpc/info.go
Outdated
| sdkCtx := i.ctxProvider(LatestCtxHeight) | ||
| chainConfig := types.DefaultChainConfig().EthereumConfig(i.keeper.ChainID(sdkCtx)) | ||
| blockTime := uint64(sdkCtx.BlockTime().Unix()) | ||
| fee := blobfee.BlobBaseFeeForNextBlock(chainConfig, blockTime, nil) |
There was a problem hiding this comment.
Hm this effectively returns a constant. Why all the allocations before it?
Could we not just return the constant here?
x/evm/blobfee/blobfee.go
Outdated
| _ = chainConfig | ||
| _ = blockTime | ||
| _ = excessBlobGas | ||
| // Cancun not enabled / no dynamic blob fee: fixed 1 wei (matches execution BlockContext). |
There was a problem hiding this comment.
Could you point me to the settings that confirm this please?
x/evm/blobfee/blobfee.go
Outdated
| func BlobBaseFeeForNextBlock(chainConfig *params.ChainConfig, blockTime uint64, excessBlobGas *uint64) *big.Int { | ||
| _ = chainConfig | ||
| _ = blockTime | ||
| _ = excessBlobGas |
|
Discussed in 1:1:
Overall, do the same for all unimplemented EVM API methods first to then put EVM tests in the critical path of CI passing. Then communicate a list of all such methods to the team and discuss which ones we will not support (at least for now) and which ones we want to fix to nurture ecosystem growth. |
Describe your changes and provide context
Fixes PLT-161
Ref: PLT-161
Testing performed to validate your change