Skip to content

chore(evmrpc): expose eth_blobBaseFee on eth RPC surface#3080

Open
mojtaba-esk wants to merge 6 commits intomainfrom
mojtaba/expose-eth_blobBaseFee-on-eth-RPC-surface
Open

chore(evmrpc): expose eth_blobBaseFee on eth RPC surface#3080
mojtaba-esk wants to merge 6 commits intomainfrom
mojtaba/expose-eth_blobBaseFee-on-eth-RPC-surface

Conversation

@mojtaba-esk
Copy link
Contributor

Describe your changes and provide context

Fixes PLT-161

Ref: PLT-161

Testing performed to validate your change

@github-actions
Copy link

github-actions bot commented Mar 17, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 17, 2026, 5:19 PM

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.39%. Comparing base (4282c07) to head (ff9c0ae).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3080   +/-   ##
=======================================
  Coverage   58.39%   58.39%           
=======================================
  Files        2088     2088           
  Lines      172108   172067   -41     
=======================================
- Hits       100506   100487   -19     
+ Misses      62656    62635   -21     
+ Partials     8946     8945    -1     
Flag Coverage Δ
sei-chain-pr 67.47% <100.00%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
evmrpc/info.go 77.68% <100.00%> (+0.73%) ⬆️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integration_test/evm_module/rpc_io_test/testdata/eth_blobBaseFee/get-current-blobfee.iox needs updating too right?

Separately, we have eip4844.CalcBlobFee that is used in a few places. Checking that you have seen it and there is a good reason not to use it here?

evmrpc/info.go Outdated
sdkCtx := i.ctxProvider(LatestCtxHeight)
chainConfig := types.DefaultChainConfig().EthereumConfig(i.keeper.ChainID(sdkCtx))
blockTime := uint64(sdkCtx.BlockTime().Unix())
fee := blobfee.BlobBaseFeeForNextBlock(chainConfig, blockTime, nil)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm this effectively returns a constant. Why all the allocations before it?
Could we not just return the constant here?

_ = chainConfig
_ = blockTime
_ = excessBlobGas
// Cancun not enabled / no dynamic blob fee: fixed 1 wei (matches execution BlockContext).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you point me to the settings that confirm this please?

func BlobBaseFeeForNextBlock(chainConfig *params.ChainConfig, blockTime uint64, excessBlobGas *uint64) *big.Int {
_ = chainConfig
_ = blockTime
_ = excessBlobGas
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why take args at all?

@masih
Copy link
Collaborator

masih commented Mar 17, 2026

Discussed in 1:1:

  • return an explicit method not found with an optional message to say Sei does not support this
  • check that documentation is reflective of this

Overall, do the same for all unimplemented EVM API methods first to then put EVM tests in the critical path of CI passing. Then communicate a list of all such methods to the team and discuss which ones we will not support (at least for now) and which ones we want to fix to nurture ecosystem growth.

@mojtaba-esk mojtaba-esk requested a review from masih March 17, 2026 16:57
@mojtaba-esk mojtaba-esk enabled auto-merge March 17, 2026 17:22
@mojtaba-esk mojtaba-esk added this pull request to the merge queue Mar 17, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants