Open
Conversation
Check raw Cosmos signature bytes and canonical EVM payload sizes so malformed tx wrappers cannot smuggle extra signatures, derived data, or embedded eth tx fields past stateless validation. Made-with: Cursor
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3073 +/- ##
==========================================
- Coverage 58.76% 58.42% -0.34%
==========================================
Files 2090 2088 -2
Lines 172323 172038 -285
==========================================
- Hits 101257 100516 -741
- Misses 62090 62591 +501
+ Partials 8976 8931 -45
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Validate wrapped Cosmos envelope fields via the proto tx and enforce semantic tx-data validation so padded addresses, signatures, and access-list fields cannot survive canonicalization into mempool-accepted EVM transactions. Made-with: Cursor
Run the existing EVM wrapper and message validators in the actual Giga executor entrypoint so Giga execution rejects bloated envelope fields and non-canonical tx payloads before any execution logic or state changes. Made-with: Cursor
sei-will
approved these changes
Mar 17, 2026
Clear unknown bytes from the canonical MsgEVMTransaction re-marshal and explicitly reject unknown fields on the outer Any wrapper so protobuf padding cannot bypass the field-bloat check. Made-with: Cursor
sei-will
approved these changes
Mar 17, 2026
yzang2019
approved these changes
Mar 17, 2026
Resolve the app/app.go conflict by keeping main's Giga stateless validation and panic handling flow while preserving the field-bloat coverage and updated Giga runtime tests on this branch. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan