Open
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
blindchaser
reviewed
Mar 17, 2026
| for (let i = 0; i < numTxs; i++) { | ||
| const tx = evmTester.setUint256Var(i + 1000, { | ||
| gasPrice: ethers.parseUnits("100", "gwei"), | ||
| nonce: await owner.getNonce() + i, |
Contributor
There was a problem hiding this comment.
from ai:
getNonce() returns the pending nonce count by default in ethers v6. If the provider's pending pool updates between loop iterations (e.g., after the first tx is sent), getNonce() may already reflect the pending tx, causing getNonce() + i to skip nonce values.
Fix: Capture the base nonce once before the loop:
blindchaser
reviewed
Mar 17, 2026
| const { expect } = require("chai"); | ||
| const hre = require("hardhat"); | ||
| const { ethers } = hre; | ||
| const { deployEvmContract, setupSigners, fundAddress } = require("./lib"); |
blindchaser
reviewed
Mar 17, 2026
|
|
||
| before(async function () { | ||
| contractAddress = await evmTester.getAddress(); | ||
| await sleep(3000); // wait for a fresh block |
Contributor
There was a problem hiding this comment.
3 seconds it may be too long, how about
const startBlock = await ethers.provider.getBlockNumber();
while ((await ethers.provider.getBlockNumber()) === startBlock) {
await sleep(500);
}
blindchaser
approved these changes
Mar 17, 2026
Kbhat1
approved these changes
Mar 17, 2026
yzang2019
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Right now, our integration tests spin up docker containers with pebbledb as receiptdb, which is currently used in mainnet. We do not have integration tests that test the parquet implementation of receiptdb. This PR adds that. Once parquet is sufficiently rolled out, we will deprecate these tests and have the default integration tests use parquet.
Testing performed to validate your change
integration tests.