Try to fix this plugin for newer Django CMS (3.7)#1
Open
oxytu wants to merge 21 commits intosarah-github:masterfrom
Open
Try to fix this plugin for newer Django CMS (3.7)#1oxytu wants to merge 21 commits intosarah-github:masterfrom
oxytu wants to merge 21 commits intosarah-github:masterfrom
Conversation
oxytu
commented
Jun 11, 2020
oxytu
commented
- Based on Branch by @sarah-github
- Incorporated Feedback from @marcosguedes on Pullrequest for usage with djangocms-3.6.0 mishbahr/djangocms-forms#75
properties don't have parenthases
This should cause the PyPi package to auto-sync with the release.
…y fix some of the stats on PyPi.
- Based on Branch by @sarah-github - Incorporated Feedback from @marcosguedes on Pullrequest mishbahr#75
|
Hey @oxytu, would you consider pushing this to the fork by @avryhof? He has the djangocms-forms-maintained package on PyPi and his update for cms 3.6 is also based on @sarah-github's fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.