fix(runners): guard against empty loss_history in all trainers#36
Merged
sacredvoid merged 1 commit intomainfrom Mar 26, 2026
Merged
fix(runners): guard against empty loss_history in all trainers#36sacredvoid merged 1 commit intomainfrom
sacredvoid merged 1 commit intomainfrom
Conversation
When max_steps < logging_steps, loss_history is empty, causing IndexError in notebooks and CLI. Now falls back to [training_loss] from TRL's result object when no log entries contain loss. Fixes #35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if not loss_history: loss_history = [result.training_loss]fallback in SFT, DPO, and GRPO train methodsmax_steps < logging_stepsproduces no log entries with lossFixes #35
Test plan