fix(eval): copy preset list to prevent aliasing mutation#32
Merged
sacredvoid merged 1 commit intomainfrom Mar 26, 2026
Merged
Conversation
The preset resolver assigned BENCHMARK_PRESETS[key] directly to self.tasks, so mutating config.tasks corrupted the shared preset dict for all future configs in the same process. Now copies with list(). Fixes #31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BENCHMARK_PRESETS[key]inlist()to create a copy instead of aliasing the shared dictconfig.tasks.append("x")permanently corrupted the preset for all future configsFixes #31
Test plan
test_preset_tasks_not_aliased_to_shared_dict