fix(eval): exclude booleans from parsed benchmark metrics#30
Merged
sacredvoid merged 1 commit intomainfrom Mar 26, 2026
Merged
Conversation
bool is a subclass of int in Python, so isinstance(True, (int, float)) returns True. Boolean metadata from lm-eval results was leaking into benchmark metrics as 1/0. Added explicit bool exclusion. Fixes #29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
and not isinstance(v, bool)guard to the metric filter inparse_resultsboolis a subclass ofintin Python, soisinstance(True, (int, float))returnsTrueFixes #29
Test plan
test_filters_booleansverifies True/False are excluded