Open
Conversation
ksco
reviewed
Mar 29, 2026
ksco
left a comment
ksco
left a comment
There was a problem hiding this comment.
The implementation of any_bit_set and is_ascii looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a LSX and a LASX-accelerated implementation for loongarch64. LSX is present on virtually almost all LoongArch processors, LASX is present on workstation and server CPUs.
The performance is not super great, especially on non-latin input, but the penalty over std is mostly acceptable:
basic = LSX
basic_lasx = LASX
std = std
Benchmarked and validated on a Loongson 3B6000 12-core CPU @ 2.2 GHz. It passes all tests.