Skip to content

add ACLE random number generation intrinsics#2050

Merged
sayantn merged 3 commits intorust-lang:mainfrom
folkertdev:aarch64-rand
Mar 16, 2026
Merged

add ACLE random number generation intrinsics#2050
sayantn merged 3 commits intorust-lang:mainfrom
folkertdev:aarch64-rand

Conversation

@folkertdev
Copy link
Contributor

tracking issue: rust-lang/rust#153514

@folkertdev
Copy link
Contributor Author

cc @adamgemmell to check that this makes sense.

Internally the feature appears to be called rng, but LLVM uses rand as the target feature name. The rand target feature is already stable, it just looks like the intrinsics for it were never added.

@folkertdev folkertdev marked this pull request as ready for review March 6, 2026 20:47
@rustbot
Copy link
Collaborator

rustbot commented Mar 6, 2026

r? @sayantn

rustbot has assigned @sayantn.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Amanieu, @folkertdev, @sayantn
  • @Amanieu, @folkertdev, @sayantn expanded to Amanieu, folkertdev, sayantn
  • Random selection from Amanieu, sayantn

Copy link
Contributor

@sayantn sayantn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly lgtm, just some nits

View changes since this review

@folkertdev folkertdev force-pushed the aarch64-rand branch 3 times, most recently from 0cf01e1 to 709ece1 Compare March 12, 2026 22:27
@sayantn
Copy link
Contributor

sayantn commented Mar 16, 2026

Sorry for the delay, LGTM

@sayantn sayantn added this pull request to the merge queue Mar 16, 2026
Merged via the queue into rust-lang:main with commit aa3fc33 Mar 16, 2026
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants