Skip to content

Add E0790 as more specific variant of E0283#98028

Merged
bors merged 2 commits intorust-lang:masterfrom
aticu:master
Jul 19, 2022
Merged

Add E0790 as more specific variant of E0283#98028
bors merged 2 commits intorust-lang:masterfrom
aticu:master

Conversation

@aticu
Copy link
Contributor

@aticu aticu commented Jun 12, 2022

Fixes #81701

I think this should be good to go, there are only two things where I am somewhat unsure:

  • Is there a better way to get the fully-qualified path for the suggestion? I tried self.tcx.def_path_str, but that didn't seem to always give a correct path for the context.
  • Should all this be extracted into it's own method or is it fine where it is?

r? @estebank

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E0283 could be better for calls to associated functions on the trait itself