Make def names and HIR names consistent.#95435
Merged
bors merged 3 commits intorust-lang:masterfrom Apr 10, 2022
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name in the
DefKeyis interned to create theDefId, so it does notrequire any query to access. This can be leveraged to avoid a few useless
HIR accesses for names.
In order to achieve that, generic parameters created from universal
impl-trait are given the pretty-printed ast as a name, instead of
{{opaque}}.Drive-by: theTyCtxt::opt_item_nameused a dummy span for non-localdefinitions. We have access to
def_ident_span, so we use it.