Make symbols stripping work on MacOS X#82037
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 10, 2021
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in the stabilization issue, MacOS' linker doesn't support the
-sand-Sflags to strip symbols anymore. However, the os ships a separated tool to perform these operations.This change allows the compiler to use that tool after a target has been compiled to strip symbols.
For rationale, see: #72110 (comment)
For option selection, see: https://www.unix.com/man-page/osx/1/strip/
Signed-off-by: David Calavera david.calavera@gmail.com