Store idents for DefPathData into crate metadata#70077
Merged
bors merged 2 commits intorust-lang:masterfrom Mar 24, 2020
Merged
Store idents for DefPathData into crate metadata#70077bors merged 2 commits intorust-lang:masterfrom
DefPathData into crate metadata#70077bors merged 2 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we threw away the
Spanassociated with a definition'sidentifier when we encoded crate metadata, causing us to lose location
and hygiene information.
We now store the identifier's
Spanin a side table, which gets encodedinto the crate metadata. When we decode items from the metadata, we
combine the name and span back into an
Ident.This improves the output of several tests, which previously had messages
suppressed due to dummy spans.
This is a prerequisite for #68686, since throwing away a
Spanmeansthat we lose hygiene information.