Don't bug when taking discriminant of generator during dataflow#69562
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 1, 2020
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proper fix for rust-lang/rust-clippy#5239.
Rvalue::Discriminantis used on generators as well asenums. This didn't cause a test failure inrustcsince we don't need to do any dataflow passes until after the generator transform that adds theRvalue::Discriminant.This required a small refactoring.
diff -wis beneficial.r? @oli-obk
cc @JohnTitor