Allow trait methods to be called on concrete types in a const context#68847
Merged
bors merged 16 commits intorust-lang:masterfrom Feb 20, 2020
Merged
Allow trait methods to be called on concrete types in a const context#68847bors merged 16 commits intorust-lang:masterfrom
bors merged 16 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially implements RFC 2632 by const-checking methods inside an
impl constblock and allowing those methods to be called on concrete types. Calling trait methods on type parameters in a const context is not yet allowed. Implementing this will require much more work. Since we are only concerned with methods on concrete types, we are able to take advantage of the machinery inInstance::resolve, which is doing most of the work.This also propagates
#[rustc_const_unstable]from parent items to child items, making that attribute behave like#[stable]and#[unstable]do. This allows trait methods to be marked as unstably const.cc #67792 #57563
cc @rust-lang/wg-const-eval
r? @oli-obk