Get rid of the Scalar and ScalarPair variants of ConstValue...#55260
Closed
oli-obk wants to merge 24 commits intorust-lang:masterfrom
Closed
Get rid of the Scalar and ScalarPair variants of ConstValue...#55260oli-obk wants to merge 24 commits intorust-lang:masterfrom
Scalar and ScalarPair variants of ConstValue...#55260oli-obk wants to merge 24 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... by always using
ByRefand reading the scalars from the backingAllocationwhere desiredOh god this uncovered so many bugs and bugs-just-waiting-to-happen. I'm still not fully done, but I don't want to grow this PR any further. It is in a sane state except for the
const_fieldfunction, which was hacky to begin with.fixes #54738
r? @RalfJung