Improve check-cfg expected names diagnostic#136016
Merged
bors merged 3 commits intorust-lang:masterfrom Jan 26, 2025
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the check-cfg
allow-same-leveltest bynormalizing it's output and byadding more context to the test.It also filters the well known cfgs from the
expected names arenote, as to reduce the size of the diagnostic. Users can still find the full list on the rustc book, which is reinforced for Cargo users by adding a note in the Cargo check-cfg specific section.Fixes #135995
r? @jieyouxu