Use Default visibility for rustc-generated C symbol declarations#131519
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 11, 2024
Merged
Use Default visibility for rustc-generated C symbol declarations#131519bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-default visibilities should only be used for definitions, not declarations, otherwise linking can fail.
This is based on #123994.
Issue #123427
When I changed
default-hidden-visibilitytodefault-visibilityin #130005, I updated all places in the code that useddefault-hidden-visibility, replicating the hidden-visibility bug to also happen for protected visibility.Without this change, trying to build rustc with
-Z default-visibility=protectedfails with a link error.