float types: move copysign, abs, signum to libcore#131304
Merged
bors merged 5 commits intorust-lang:masterfrom Nov 14, 2024
Merged
float types: move copysign, abs, signum to libcore#131304bors merged 5 commits intorust-lang:masterfrom
bors merged 5 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These operations are explicitly specified to act "bitwise", i.e. they just act on the sign bit and do not even quiet signaling NaNs. We also list them as "non-arithmetic operations", and all the other non-arithmetic operations are in libcore. There's no reason to expect them to require any sort of runtime support, and from these experiments it seems like LLVM indeed compiles them in a way that does not require any sort of runtime support.
Nominating for @rust-lang/libs-api since this change takes immediate effect on stable.
Part of #50145.