Only add an automatic SONAME for Rust dylibs#130960
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 28, 2024
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#126094 added an automatic relative
SONAMEto all dynamic libraries, but it was really only needed for Rust--crate-type="dylib". In Fedora, it was a surprise to seeSONAMEon"cdylib"libraries like Python modules, especially because that generates an undesirable RPMProvides. We can instead add aSONAMEjust for Rust dylibs by passing the crate-type argument farther.Ref: https://bugzilla.redhat.com/show_bug.cgi?id=2314879