Allow limited access to OsStr bytes#109698
Merged
bors merged 6 commits intorust-lang:masterfrom May 31, 2023
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OsStrhas historically kept its implementation details private out ofconcern for locking us into a specific encoding on Windows.
This is an alternative to #95290 which proposed specifying the encoding on Windows. Instead, this
only specifies that for cross-platform code,
OsStr's encoding is a superset of UTF-8 and definesrules for safely interacting with it
At minimum, this can greatly simplify the
os_str_bytescrate and everyarg parser that interacts with
OsStrdirectly (which is most of thosethat support invalid UTF-8).
Tracking issue: #111544