fix: don't offer unwrap result/option return type assist in trait impls#21831
Closed
Albab-Hasan wants to merge 1 commit intorust-lang:masterfrom
Closed
fix: don't offer unwrap result/option return type assist in trait impls#21831Albab-Hasan wants to merge 1 commit intorust-lang:masterfrom
Albab-Hasan wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
Assists aren't required to produce compilable code, and this can be useful even in trait methods (for example, if you want to change the trait signature as well). |
Contributor
Author
|
@ChayimFriedman2 youre right. my mistake. shouldve done more research before making the pr. ill close it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #13560
the
unwrap_result_return_typeandunwrap_option_return_typeassists were incorrectly offered inside trait impl methods. applying the assist removes the return type breaking the trait contract and producing a compile error.this fix disables both assists when the function is a trait impl method, checked via
implemented_trait. this approach was chosen over showing the assist with a warning, since silently producing uncompilable code is wrong behavior.added a test to cover this case.