Deprecate tuple_combinations#1085
Open
phimuemue wants to merge 6 commits intorust-itertools:masterfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1085 +/- ##
==========================================
- Coverage 94.38% 93.81% -0.58%
==========================================
Files 48 51 +3
Lines 6665 6468 -197
==========================================
- Hits 6291 6068 -223
- Misses 374 400 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I left the original tests, and added their array_combination counterparts.
I left the original tests, array_combination counterparts already present.
I left the original tests, and added their array_combination counterparts. Note that they do not panic, and I saw no reason why they should.
phimuemue
force-pushed
the
deprecate_tuple_combinations
branch
from
4c0a468 to
95a78e3
Compare
Member
Author
|
@jswrenn gentle nudge. OT: Should we publish 0.15? We had some bug-fixes and other improvements, plus it would make things easier if CI would not fail on each PR. Even more OT: Can/should we automate publishing somehow? afaik, I'm not allowed to publish to crates.io, but if I can help, let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As agreed upon in #1084 (comment)