Run clippy against Arm build targets.#630
Draft
wt wants to merge 1 commit intorust-embedded:masterfrom
Draft
Conversation
Contributor
Author
|
@thejpster I pushed the clippy ci change here. I think I made the updates you wanted. |
thejpster
approved these changes
Mar 21, 2026
Contributor
thejpster
left a comment
thejpster
left a comment
There was a problem hiding this comment.
LGTM, but I think we need to change the name of the job that PRs require before merging, because this matrix changes the name of the jobs?
Pinging @adamgreig for a second opinion.
wt
force-pushed
the
make_clippy_run_on_multiple_targets
branch
4 times, most recently
from
5776672 to
37663ef
Compare
The current clippy runs are running against an X86 build of the code This will make clippy exercise the Arm specfic code. I have only enabled 2 as some jobs were cancelled when I enabled all 7 targets.
wt
force-pushed
the
make_clippy_run_on_multiple_targets
branch
from
37663ef to
4ab2801
Compare
Contributor
Author
|
I updated to a more realistically useful config if we are going to run against multiple targets. This one run clippy on the default target on everything and only runs multiple targets for the cortex dev crates. I did this by exclusion so that new crates are, by default, included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current clippy runs are running against an X86 build of the code This will make clippy exercise the Arm specfic code. I have only enabled 2 as some jobs were cancelled when I enabled all 7 targets.