Open
Conversation
wt
force-pushed
the
update_asm_toolchain
branch
4 times, most recently
from
0fe3a7c to
2abb7dd
Compare
wt
force-pushed
the
update_asm_toolchain
branch
4 times, most recently
from
ec6c7ef to
667de8f
Compare
wt
force-pushed
the
update_asm_toolchain
branch
20 times, most recently
from
ac4ddc1 to
42c98c1
Compare
wt
force-pushed
the
update_asm_toolchain
branch
4 times, most recently
from
fd3ccb5 to
edb22b0
Compare
Contributor
Author
|
@thejpster @jonathanpallant @adamgreig Reviewers, please double check the new crate (in cortex-m/macros). I'm assuming that the cortex-m crate using the new crate will need to be updated to use an actual version once it is published. Can we just publish the new crate once this is landed so that I can make a PR to depend on the published version? |
wt
force-pushed
the
update_asm_toolchain
branch
from
edb22b0 to
e53eba0
Compare
Contributor
|
You can depend on a version and a path at the same time. |
Contributor
Author
Can I depend on a path in a published crate, like "cortex-m"? |
Contributor
|
As long as you have both. It uses the path if valid, and falls back to the version if not. |
wt
force-pushed
the
update_asm_toolchain
branch
from
e53eba0 to
63bee36
Compare
Contributor
Author
|
I have updated the dep spec for the new crate to include the version number. I use an exact version like the |
jonathanpallant
requested changes
Mar 20, 2026
The `cm7-r0p1` feature only works with the plateform feature `armv7em`. I added a compile error to help someone figure that out more redily if they accidentally combine those features.
This will allow getting all the asm in shape for edition 2024.
wt
force-pushed
the
update_asm_toolchain
branch
from
63bee36 to
fe62ca1
Compare
Contributor
Author
|
I removed the |
wt
force-pushed
the
update_asm_toolchain
branch
from
fe62ca1 to
dd25b47
Compare
thejpster
reviewed
Mar 22, 2026
wt
force-pushed
the
update_asm_toolchain
branch
from
dd25b47 to
94fb96a
Compare
Inline asm has been supported in stable rust for some time, so I removed the separate asm build infra and added that code to the normal crate code. I also crated a mock of the asm functions that were needed to run clippy with a non-arm target (like x86_64).
The purpose of this attribute is to allow platforms that do not support the asm instructions to compile code code that calls those functions. This is needed so that clippy can be run once in CI and when testing locally.
This is the first step of removing the asm::inner module entirely.
This removes the inner module entirely.
The more I think about this, the more I think this is more correct. Considering that the argument is owned, by the function, it seems more correct to just recognize that in the signature. It is not a breaking change since the arg is passed by value since it's a primitive type, so I think this is better. In principle, I would prefer to merge this with the commit that moves the asm code into the crate directly instead of this separate commit.
wt
force-pushed
the
update_asm_toolchain
branch
from
94fb96a to
1ef6c56
Compare
I used `any(armv6m, armv7m, ...)` in many places where I could have said `cortex_m` instead for the cfg macro calls. Let's change that.
wt
force-pushed
the
update_asm_toolchain
branch
from
e0d3ab8 to
3188915
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft for updating the asm toolchain. It's based on my #628, so it shouldn't be landed before that is.