Conversation
Stub expand url call in test
|
Testing this requires the previous pull requests... before merging, ensure you can |
There was a problem hiding this comment.
sure. I was thinking of also moving the expansion to the tweet processing leve, but since that would be destructive, was considering adding an 'original tweet text' field. Unrelated, I want to add a 'context' field that represents the search term the tweet was found from, then... eventually extract most of this as an engine.. :)
There was a problem hiding this comment.
I'm rewriting this to add a tweet_display_text field that is populated at import time.. should I continue to update this pull request?
There was a problem hiding this comment.
Just make it easy to merge and I'll do so.. Keep adding tests and I don't mind merging at a faster rate, given the feature is not going to bloat the code base -- aka, it is derived from something needed, with a reason that outweighs the expense of maintenance moving forward..
Needs tests and redesign, but otherwise works