Add Options class and switch Application to use it instead of anonymous Struct#694
Open
Add Options class and switch Application to use it instead of anonymous Struct#694
Conversation
…us Struct for CLI options
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #564 by replacing the anonymous Struct used for application options with a named Rake::Options class. This improves error messages by showing Rake::Options instead of #<Class:0x...> when undefined methods are called on the options object.
Changes:
- Created a new
Rake::Optionsclass with all 20 option attributes from the original Struct - Updated
Application#optionsto instantiateOptions.newinstead of the anonymous Struct - Added appropriate require statements in both
lib/rake.rbandlib/rake/application.rb
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/rake/options.rb | New file defining the Rake::Options class with attr_accessors for all 20 application options |
| lib/rake/application.rb | Updated options method to use Options.new instead of anonymous Struct, added require statement |
| lib/rake.rb | Added require statement for the new Options class |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #564