Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f789203882
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/index.ts
Outdated
| api.transform( | ||
| { | ||
| test: { and: [/\.(jsx?|tsx?)$/, { not: [/node_modules/] }] }, | ||
| test: { and: [/\.(jsx?|tsx?|vue)$/, { not: [/node_modules/] }] }, |
There was a problem hiding this comment.
Narrow this matcher before enabling .vue: api.transform rules match by resourcePath, so Vue SFC subrequests like App.vue?vue&type=style... still satisfy /\.(jsx?|tsx?|vue)$/. That makes this transform run on non-entry Vue submodules and prepend a JS import to code that is not the main SFC module, which can break builds for common components that include <style> blocks. Add a resourceQuery guard (or equivalent) so only the intended Vue module request is transformed.
Useful? React with 👍 / 👎.
1 participant
Summary
.vuefiles.