Skip to content

chore: upgrade TypeScript to 6.0.2#45

Merged
chenjiahan merged 1 commit intomainfrom
codex/upgrade-typescript-6-0-2
Mar 28, 2026
Merged

chore: upgrade TypeScript to 6.0.2#45
chenjiahan merged 1 commit intomainfrom
codex/upgrade-typescript-6-0-2

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

  • Upgrade TypeScript to 6.0.2.
  • Replace the root tsconfig.json with the shared NodeNext configuration.
  • Validate the change with pnpm build and pnpm test.

Related Links

Copilot AI review requested due to automatic review settings March 28, 2026 10:54
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the TypeScript version to 6.0.2 and modifies the tsconfig.json configuration, including updating the target to ES2023 and switching to nodenext for module resolution. Feedback was provided regarding the removal of the strict compiler option, which is recommended to be kept for better type safety.

@chenjiahan chenjiahan merged commit 9fec78d into main Mar 28, 2026
7 checks passed
@chenjiahan chenjiahan deleted the codex/upgrade-typescript-6-0-2 branch March 28, 2026 10:58
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the project’s TypeScript toolchain to v6.0.2 and aligns compilation settings with a NodeNext/ESM-oriented tsconfig.json.

Changes:

  • Upgrade typescript to 6.0.2 (and update lockfile accordingly).
  • Replace the root tsconfig.json compiler options with a NodeNext-focused configuration.
  • Reformat package.json (whitespace/structure) while updating the TypeScript devDependency.

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.

File Description
tsconfig.json Updates compiler options for NodeNext module resolution and newer ECMAScript target/output layout.
package.json Pins TypeScript to 6.0.2 and normalizes formatting.
pnpm-lock.yaml Locks TypeScript 6.0.2 and updates peer/optional dependency resolution entries.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"nano-staged": "^0.9.0",
"playwright": "^1.58.2",
"simple-git-hooks": "^2.13.1",
"typescript": "6.0.2"
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading to TypeScript 6.0.2 may be incompatible with the currently locked build tooling: rsbuild-plugin-dts@0.20.0 (pulled in via @rslib/core@0.20.0) declares a peerDependencies.typescript of ^5, so this change will likely produce peer-dependency warnings and may break d.ts generation. Consider bumping @rslib/core (and/or rsbuild-plugin-dts) to a version that supports TS 6 (e.g. rsbuild-plugin-dts@0.20.1+ which widens the peer range).

Copilot uses AI. Check for mistakes.

typescript@5.9.3:
resolution: {integrity: sha512-jl1vZzPDinLr9eUt3J/t7V6FgNEw9QjvBPdysz9KfQDD41fQrC2Y4vKQdiaUpFT4bXlb1RHhLpp8wtm6M5TgSw==}
typescript@6.0.2:
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typescript@6.0.2 is now locked, but rsbuild-plugin-dts@0.20.0 (also in this lockfile) declares peerDependencies.typescript: ^5. This unsupported peer range will typically cause install warnings and can break the d.ts build; consider updating the toolchain to a version that supports TS 6 (e.g. rsbuild-plugin-dts@0.20.1+, likely via bumping @rslib/core).

Suggested change
typescript@6.0.2:
typescript@5.5.4:

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants