Added method unselectTabAtPosition#370
Open
anapsil wants to merge 1 commit intoroughike:masterfrom
anapsil:master
Open
Added method unselectTabAtPosition#370anapsil wants to merge 1 commit intoroughike:masterfrom anapsil:master
anapsil wants to merge 1 commit intoroughike:masterfrom
anapsil:master
Conversation
|
please, merge this PR |
Collaborator
|
@roughike what do you think, should we take this change? let me know your thoughts about it. |
Owner
|
I'm still thinking what would be a valid use case for this? |
|
A case would be if you use the bottom bar for main navigation but you have an option item in the toolbar (e.g. account), which should show a fragment which is not a bottom bar navigation item. |
issotina
approved these changes
Sep 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolved issue #324 for me