fix: exception reporting that raise in early/lazy deploy modes#553
Open
doudou wants to merge 3 commits intotransition-to-runkitfrom
Open
fix: exception reporting that raise in early/lazy deploy modes#553doudou wants to merge 3 commits intotransition-to-runkitfrom
doudou wants to merge 3 commits intotransition-to-runkitfrom
Conversation
…iate This fixes tests that created the generator "by hand" and were actually never enabling the features.
…xception explanations With early_deploy set, in some cases the exception would be generated, but then would not get a merge failure explanation, which was (1) leading to an exception in pretty-printing and (2) failing to actually explain what was going on.
jhonasiv
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core issue was that some tests were not executed with the relevant feature flags because of missing defaults. In addition, starting to develop bundles with early deploy ON by default led to triggering some bugs in error reporting.
Fix both, and add unit tests.