Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
There was a problem hiding this comment.
3 issues found across 8 files
Confidence score: 2/5
- There are concrete user-facing regressions in
packages/editor/src/ui/inspector/hooks/use-numeric-input.ts: pressing Escape can still persist edits on blur, which breaks expected cancel behavior. packages/editor/src/ui/inspector/hooks/use-numeric-input.tsalso mis-handles valid0during arrow key increment/decrement because||falls back incorrectly, so numeric edits can produce wrong values.- Given the high severity/confidence on both input-handling bugs, this carries high merge risk until those paths are corrected.
- Pay close attention to
packages/editor/src/ui/inspector/hooks/use-numeric-input.ts,packages/editor/src/ui/inspector/hooks/use-drag-to-change.ts- cancel/commit behavior, zero-value stepping logic, and drag cleanup on pointer cancellation need verification.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/editor/src/ui/inspector/hooks/use-numeric-input.ts">
<violation number="1" location="packages/editor/src/ui/inspector/hooks/use-numeric-input.ts:80">
P1: Escape can still commit the edited value on blur, so canceling edits may incorrectly persist changes.</violation>
<violation number="2" location="packages/editor/src/ui/inspector/hooks/use-numeric-input.ts:105">
P1: Arrow key increments/decrements mis-handle valid `0` because `||` falls through to `fallbackValue`.</violation>
</file>
<file name="packages/editor/src/ui/inspector/hooks/use-drag-to-change.ts">
<violation number="1" location="packages/editor/src/ui/inspector/hooks/use-drag-to-change.ts:71">
P2: Handle pointer cancellation the same as pointer up so drag cleanup always runs.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Remove inspector.css (deferred to primitives PR) - Remove unused @radix-ui/react-slot dependency - Fix sidebar overflow in document-inspector example
d754073 to
17be03a
Compare
9aeacc3 to
6cd5d52
Compare
6cd5d52 to
5bd34db
Compare
5bd34db to
f3452c2
Compare
3871bef to
fd0246f
Compare
f3452c2 to
61aaa75
Compare
3f2ebfd to
33bd0ca
Compare
33bd0ca to
48849cb
Compare
|
Auto-merge enabled (squash) via PR Sentinel. |
2b74476 to
5f00899
Compare
5f00899 to
ff14097
Compare
Summary
Stacks on #3170
Summary by cubic
Adds four inspector hooks for colors, links, drag-to-change, and numeric inputs in the editor inspector. Includes tests, removes
use-collapsible-sections, restores@react-email/*test stubs, and applies lint/review fixes.New Features
use-document-colors: Finds unique hex colors from theme CSS and inline styles; normalizes to 6-digit; skips black/white.use-link-mark: Reads linkhref/style/isActive; helpersgetLinkColorandupdateLinkColor.use-drag-to-change: Horizontal drag to change numbers;step, Shift×10; min clamp; sets cursor and user-select.use-numeric-input: Arrow inc/dec (Shift×10), min clamp, empty handling; Enter/blur commit; Escape restores; optionalfallbackValue.Refactors
use-collapsible-sections.@react-email/render,@react-email/markdown, and@react-email/components.biomelint and review feedback fixes.Written for commit ff14097. Summary will update on new commits.