feat: add useDocumentElement option#54
Open
johngeorgewright wants to merge 1 commit intorenatorib:masterfrom
Open
feat: add useDocumentElement option#54johngeorgewright wants to merge 1 commit intorenatorib:masterfrom
johngeorgewright wants to merge 1 commit intorenatorib:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using other libraries which use an alternative way in finding the window size (document width) (
document.documentElement.clientWidth). Which, unlikewindow.innerWidth, doesn't add the width of the body's scroll bar to it's final value. The difference in pixels will differ from OS, browser & any additional UI enhancements, and trying to use react-sizes with these libraries can be troublesome.Below is an example of how chrome will differ, between these 2 values, in windows 10.
It would be nice if either
react-sizesused document width too, or at least had the ability to do so. This pull request adds a configuration option to use the document width instead.There are a few changes in this pull request added by prettier, which I did not add myself (just incase you thought I was being unhelpfully pedantic).