Closed
Conversation
- Switch from Docker Hub to AWS ECR Public Gallery for base images to avoid rate limiting issues (addresses #268) - Use build args for PHP and Composer versions, allowing version flexibility without changing the Dockerfile - Copy Composer binary from official image into PHP base image, ensuring the PHP version used for dependency installation matches the runtime version - Add PHP version matrix to Docker build CI workflow, testing builds with all PHP versions supported by the project (currently 8.3, 8.4) This change enables Dependabot Composer updates to work correctly by decoupling the Composer version from the PHP version used in builds. https://claude.ai/code/session_01UkUqTPwnnc56NFoFqo52Lv
Keep using standard Docker Hub image references rather than switching to AWS ECR Public Gallery. https://claude.ai/code/session_01UkUqTPwnnc56NFoFqo52Lv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
PR #521 (Dependabot Composer update to 2.9.4) fails because the
composer:2.9.4image ships with PHP 8.5.2, which exceeds the project's PHP version constraint (>=8.3 <8.5). By decoupling the Composer binary from its base PHP image, we can update Composer independently of PHP version changes.Also, the Composer people discourage relying on the PHP version in their container image:
Test plan