[feat] Aggregate polling for retrieving job pending reason#3642
Open
vkarak wants to merge 1 commit intoreframe-hpc:developfrom
Open
[feat] Aggregate polling for retrieving job pending reason#3642vkarak wants to merge 1 commit intoreframe-hpc:developfrom
vkarak wants to merge 1 commit intoreframe-hpc:developfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3642 +/- ##
===========================================
- Coverage 91.70% 91.66% -0.05%
===========================================
Files 62 62
Lines 13713 13723 +10
===========================================
+ Hits 12576 12579 +3
- Misses 1137 1144 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
61c38ae to
45c5613
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the polling of jobs for the pending reason.
This is now done in a single command for all pending jobs. Two knobs are also exposed to users now as configuration options and environment variables:
slurm_job_cancel_reasons: This is a list of pending reasons that reframe will check and will cancel the job proactively.slurm_pending_job_reason_poll_freq: This controls the frequency that pending jobs will be polled for their pending reasons (valid only forslurmbackend).Closes #3640.