Skip to content

chore: Drop unneeded nolint annotations #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olivergondza wants to merge 1 commit into
base: master
Choose a base branch
from
+46 −92
Open

chore: Drop unneeded nolint annotations #1071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/helper/application_status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ import (
"time"

argoapp "github.com/argoproj-labs/argocd-operator/api/v1beta1"
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
. "github.com/onsi/ginkgo/v2"
corev1 "k8s.io/api/core/v1"
kubeerrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/application/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
package application

import (
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/gomega"
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"
"k8s.io/client-go/util/retry"

Expand All @@ -11,8 +10,7 @@ import (
"github.com/argoproj/gitops-engine/pkg/sync/common"
matcher "github.com/onsi/gomega/types"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
. "github.com/onsi/ginkgo/v2"

"context"

Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/appproject/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,8 @@ import (
matcher "github.com/onsi/gomega/types"
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

"context"

Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/argocd/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,8 @@ import (
"time"

argov1beta1api "github.com/argoproj-labs/argocd-operator/api/v1beta1"
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

matcher "github.com/onsi/gomega/types"
routev1 "github.com/openshift/api/route/v1"
Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/clusterrole/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@ package clusterrole
import (
"context"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
matcher "github.com/onsi/gomega/types"
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"
rbacv1 "k8s.io/api/rbac/v1"
Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/clusterrolebinding/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@ package clusterrolebinding
import (
"context"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
matcher "github.com/onsi/gomega/types"
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"
rbacv1 "k8s.io/api/rbac/v1"
Expand Down
3 changes: 1 addition & 2 deletions test/openshift/e2e/ginkgo/fixture/clusterserviceversion/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ package clusterserviceversion
import (
"context"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/gomega"
olmv1alpha1 "github.com/operator-framework/api/pkg/operators/v1alpha1"
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"
"k8s.io/client-go/util/retry"
Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/configmap/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@ import (
"context"
"strings"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
matcher "github.com/onsi/gomega/types"
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"
corev1 "k8s.io/api/core/v1"
Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/deployment/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,8 @@ import (
"reflect"
"strings"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

matcher "github.com/onsi/gomega/types"
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"
Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/deploymentconfig/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,9 @@ package deploymentconfig
import (
"context"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
. "github.com/onsi/ginkgo/v2"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/gomega"

matcher "github.com/onsi/gomega/types"
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"
Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,8 @@ import (
"sync"
"time"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
securityv1 "github.com/openshift/api/security/v1"

"k8s.io/apimachinery/pkg/labels"
Expand Down
3 changes: 1 addition & 2 deletions test/openshift/e2e/ginkgo/fixture/gitopsservice/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ package gitopsservice
import (
"context"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/gomega"
gitopsoperatorv1alpha1 "github.com/redhat-developer/gitops-operator/api/v1alpha1"
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"
"k8s.io/client-go/util/retry"
Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/k8s/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,8 @@ import (

"k8s.io/client-go/util/retry"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

matcher "github.com/onsi/gomega/types"
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"
Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/namespace/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@ package namespace
import (
"context"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

matcher "github.com/onsi/gomega/types"

Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/node/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,8 @@ import (
"os"
"strings"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

corev1 "k8s.io/api/core/v1"

Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/notificationsconfiguration/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@ package notificationsconfiguration
import (
"context"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

matcher "github.com/onsi/gomega/types"

Expand Down
3 changes: 1 addition & 2 deletions test/openshift/e2e/ginkgo/fixture/os/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ package os
import (
"os/exec"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
. "github.com/onsi/ginkgo/v2"
)

func ExecCommand(cmdArgs ...string) (string, error) {
Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/persistentvolume/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@ package persistentvolume
import (
"context"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
matcher "github.com/onsi/gomega/types"
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"
corev1 "k8s.io/api/core/v1"
Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/pod/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@ package pod
import (
"context"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
matcher "github.com/onsi/gomega/types"
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"
corev1 "k8s.io/api/core/v1"
Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/role/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@ import (
"context"
"reflect"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
matcher "github.com/onsi/gomega/types"
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"
rbacv1 "k8s.io/api/rbac/v1"
Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/rolebinding/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@ import (
"context"
"reflect"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
matcher "github.com/onsi/gomega/types"
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"
rbacv1 "k8s.io/api/rbac/v1"
Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/route/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@ import (
"context"
"reflect"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

matcher "github.com/onsi/gomega/types"
corev1 "k8s.io/api/core/v1"
Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/secret/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@ import (
"bytes"
"context"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
matcher "github.com/onsi/gomega/types"
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"
corev1 "k8s.io/api/core/v1"
Expand Down
6 changes: 2 additions & 4 deletions test/openshift/e2e/ginkgo/fixture/statefulset/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@ import (
"strings"
"time"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/ginkgo/v2" //nolint:all
//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

matcher "github.com/onsi/gomega/types"
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"
Expand Down
3 changes: 1 addition & 2 deletions test/openshift/e2e/ginkgo/fixture/subscription/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ import (
"github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"
corev1 "k8s.io/api/core/v1"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/gomega"
)

func GetEnv(s *olmv1alpha1.Subscription, key string) (*string, error) {
Expand Down
3 changes: 1 addition & 2 deletions test/openshift/e2e/ginkgo/fixture/utils/fixtureUtils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ import (
rbacv1 "k8s.io/api/rbac/v1"
crdv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"

//lint:ignore ST1001 "This is a common practice in Gomega tests for readability."
. "github.com/onsi/gomega" //nolint:all
. "github.com/onsi/gomega"
)

func GetE2ETestKubeClient() (client.Client, *runtime.Scheme) {
Expand Down