[GITOPS-9015]: Skip OpenshiftDexConfig when OpenShift Cluster Authentication is based on OIDC Provider#1070
Conversation
…ication is based on OIDC Provider Signed-off-by: akhil nittala <nakhil@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
go.mod and go.sum needs to be changed once upstream argocd-operator PR gets merged. |
…ication is based on OIDC Provider Signed-off-by: akhil nittala <nakhil@redhat.com>
…ication is based on OIDC Provider Signed-off-by: akhil nittala <nakhil@redhat.com>
|
@akhilnittala: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
What does this PR do / why we need it:
Currently, when an OpenShift cluster is configured with external authentication providers (such as Keycloak, Google, etc.) and the default openshift-gitops Argo CD instance also has SSO configured, authentication to the Argo CD route fails due to a Dex misconfiguration.
This PR addresses the issue by skipping the openshiftOAuth configuration when external authentication is enabled on the cluster. The operator determines this by inspecting the cluster-scoped Authentication CR and avoids configuring openshiftOAuth if spec.type is set to "OIDC".
In addition, this PR populates a condition on the Argo CD CR status to indicate that external authentication is enabled on the cluster, providing better visibility and reference for users for user created instances and also marks status.sso to Failed and creates condition.
for user-created-instances with sso on external authentication enabled clusters.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPS-9015
Fixes #?
https://issues.redhat.com/browse/GITOPS-9015
Test acceptance criteria:
How to test changes / Special notes to the reviewer: