Skip to content

ginkgo test for GITOPS-5701-1-122_validate_user_defined_appproject#1068

Open
Naveena-058 wants to merge 4 commits intoredhat-developer:masterfrom
Naveena-058:GITOPS-5701-1-122_validate_user_defined_appproject
Open

ginkgo test for GITOPS-5701-1-122_validate_user_defined_appproject#1068
Naveena-058 wants to merge 4 commits intoredhat-developer:masterfrom
Naveena-058:GITOPS-5701-1-122_validate_user_defined_appproject

Conversation

@Naveena-058
Copy link
Contributor

What does this PR do / why we need it:
Adds a new Ginkgo E2E test to validate user-defined AppProject behavior with SourceNamespaces configuration.
This ensures Applications created from allowed source namespaces are reconciled, RBAC resources are generated, and sync/health status works as expected.

This test improves coverage for namespace management and prevents regressions related to SourceNamespaces and AppProject interactions.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

https://issues.redhat.com/browse/GITOPS-5701

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot requested review from anandrkskd and jgwest February 11, 2026 10:45
svghadi
svghadi previously approved these changes Feb 12, 2026
Copy link
Member

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is mis-match between file name and test name. Rest all looks good. Thanks

/lgtm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the file name to match the test name i.e 122_validate_user_defined_appproject.

@openshift-ci openshift-ci bot removed the lgtm label Feb 12, 2026
Signed-off-by: NAVEENA S <nas@redhat.com>
@svghadi
Copy link
Member

svghadi commented Feb 12, 2026

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Feb 12, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Feb 12, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 12, 2026

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Feb 12, 2026

@Naveena-058: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-e2e c8e50c1 link true /test v4.14-e2e
ci/prow/v4.14-kuttl-parallel c8e50c1 link false /test v4.14-kuttl-parallel
ci/prow/v4.14-kuttl-sequential c8e50c1 link false /test v4.14-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants