fix: migrate from defaultProps to default parameters in all components#587
Open
alowelter wants to merge 5 commits intoreactjs:mainfrom
Open
fix: migrate from defaultProps to default parameters in all components#587alowelter wants to merge 5 commits intoreactjs:mainfrom
alowelter wants to merge 5 commits intoreactjs:mainfrom
Conversation
Collaborator
|
Thanks i quickly reviewed and looks good, i will check and merge once I'm back from vacation. And also fix the CI which looks broken. |
danez
reviewed
Sep 15, 2025
Comment on lines
+60
to
+65
| if (process.env.NODE_ENV !== 'production' && selectedIndex !== null && defaultIndex !== null) { | ||
| console.error( | ||
| 'The prop `selectedIndex` cannot be used together with `defaultIndex` in `Tabs`.\n' + | ||
| 'Either remove `selectedIndex` to let `Tabs` handle the selected tab internally or remove `defaultIndex` to handle it yourself.' | ||
| ); | ||
| } |
Collaborator
There was a problem hiding this comment.
Why was this added? Maybe this conversation from proptypes here should be done in a separate PR.
danez
reviewed
Sep 15, 2025
| onSelect, | ||
| ...attributes | ||
| }) => { | ||
| checkPropTypes(propTypes, { children, onSelect, selectedIndex }, 'prop', 'Tabs'); |
Collaborator
There was a problem hiding this comment.
defaultIndex seems missing here. OR was there a reason to no supply all props?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fix: Remove defaultProps to eliminate React 18 warnings
Problem
React 18 shows deprecation warnings for
defaultPropsin functional components, as they will be removed in a future release.Solution
defaultPropswith ES6 default parameters in function signaturesFiles Changed
src/components/Tabs.jssrc/components/TabList.jssrc/components/Tab.jssrc/components/TabPanel.jsTesting