Skip to content

Bump up lib versions#148

Open
nyandika wants to merge 23 commits intoreactdeveloperske:prodfrom
nyandika:refactor/lib-updates
Open

Bump up lib versions#148
nyandika wants to merge 23 commits intoreactdeveloperske:prodfrom
nyandika:refactor/lib-updates

Conversation

@nyandika
Copy link
Contributor

Changes proposed

There have been recent vulnerabilities in the nextjs space. Taking this chance to bump up all package versions

Also added prod branch to github actions. This necessisated a rerun of prettier and linting hence the other numerous file changes

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

N/A

Note to reviewers

N/A

@vercel
Copy link

vercel bot commented Mar 29, 2025

@nyandika is attempting to deploy a commit to the React Developers Kenya Team on Vercel.

A member of the Team first needs to authorize it.

@orama254 orama254 self-requested a review April 1, 2025 14:11
Copy link
Member

@orama254 orama254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nyandika,

Thanks for this very critical pull request. Could you check up on the conflicts emerging?

@vercel
Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
reactdevske-website Error Error Feb 9, 2026 7:38am
reactdevske-website-vuvs Error Error Feb 9, 2026 7:38am

@nyandika
Copy link
Contributor Author

nyandika commented Apr 1, 2025

Working on the failing tests. Will send an update

@nyandika
Copy link
Contributor Author

@orama254 Could you authorize this PR to deploy to vercel to get the pre-release view
I have fixed all failing tests

@orama254
Copy link
Member

@greptile

@greptile-apps
Copy link

greptile-apps bot commented Feb 16, 2026

Greptile Summary

This PR upgrades the project from Next.js 12 to 16, React 18 to 19, and updates all major dependencies to address security vulnerabilities in the Next.js ecosystem. The upgrade required migrating to new configuration formats (ESLint 9 flat config, Tailwind CSS v4, Next.js 13+ Link API) and updating deprecated APIs (images.domainsimages.remotePatterns).

Key changes:

  • Bumped Next.js (12.3.1 → 16.0.5), React (18.1.0 → 19.2.0), Tailwind (3.1.2 → 4.1.17), ESLint (8 → 9), TypeScript (4.8.4 → 5.9.3)
  • Added prod branch to GitHub Actions workflows
  • Migrated to ESLint 9 flat config format in new eslint.config.mjs
  • Updated Tailwind CSS configuration for v4 compatibility
  • Removed deprecated <a> wrappers from Next.js <Link> components
  • Fixed typo: 'Robot Mono' → 'Roboto Mono'
  • Added requestAnimationFrame optimization for initial window size reads
  • Updated e2e tests to handle bit.ly redirects properly
  • Reformatted code with Prettier after linting changes

Confidence Score: 4/5

  • Safe to merge with testing - comprehensive dependency upgrade with appropriate migration changes
  • Major version bumps across core dependencies (Next.js 12→16, React 18→19) introduce breaking changes that were properly addressed through configuration updates and API migrations. The PR author states all tests passed. The score is 4 rather than 5 due to the scale of changes requiring thorough testing in production-like environments.
  • package.json requires verification that all new dependency versions are compatible and security vulnerabilities are resolved

Important Files Changed

Filename Overview
package.json Major version bumps for Next.js (12→16), React (18→19), Tailwind (3→4), ESLint (8→9), TypeScript (4→5), and other dependencies to address security vulnerabilities
.github/workflows/validate.yml Added prod branch to CI triggers, updated GitHub Actions versions (v3→v6), and Node.js version (14.x→24.x)
next.config.js Migrated from deprecated images.domains to images.remotePatterns API, removed ESLint config (moved to eslint.config.mjs)
eslint.config.mjs New flat config format for ESLint 9, replaces legacy .eslintrc configuration
tailwind.config.js Fixed typo in font name: 'Robot Mono' → 'Roboto Mono'
postcss.config.js Updated for Tailwind CSS v4 by changing plugin from tailwindcss to @tailwindcss/postcss
tsconfig.json Changed jsx from 'preserve' to 'react-jsx' for React 19 compatibility
src/components/Navbar/Navbar.tsx Removed deprecated <a> wrapper around Next.js Link (Next 13+ requirement), added requestAnimationFrame optimization, updated z-index from z-10 to z-20

Flowchart

flowchart TD
    A[Dependency Upgrades] --> B[Next.js 12 to 16]
    A --> C[React 18 to 19]
    A --> D[Tailwind 3 to 4]
    A --> E[ESLint 8 to 9]
    A --> F[TypeScript 4 to 5]
    
    B --> G[Config Migrations]
    C --> G
    D --> G
    E --> G
    
    G --> H[next.config.js updates]
    G --> I[eslint.config.mjs created]
    G --> J[postcss.config.js updates]
    G --> K[tsconfig.json updates]
    
    B --> L[Code Updates]
    C --> L
    
    L --> M[Remove deprecated Link wrapper]
    L --> N[Remove React imports]
    L --> O[Add requestAnimationFrame]
    
    G --> P[CI/CD Updates]
    P --> Q[Add prod branch]
    P --> R[Node 24.x]
    P --> S[GitHub Actions v6]
    
    M --> T[Prettier and Lint Pass]
    N --> T
    O --> T
    
    T --> U[Tests Updated]
    U --> V[PR Ready]
Loading

Last reviewed commit: 42d4f75

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

33 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants