Update TableComponent.tsx to use deepClone function over spread.#23
Open
bendesilva wants to merge 1 commit intordunk:masterfrom
Open
Update TableComponent.tsx to use deepClone function over spread.#23bendesilva wants to merge 1 commit intordunk:masterfrom
deepClone function over spread.#23bendesilva wants to merge 1 commit intordunk:masterfrom
Conversation
…ad syntax When using the table within a block editor, having created a table, left the document and returned, adding a new row/s would result in an 'can't define property "x": "obj" is not extensible' error in the console. Both the `addRows` and `addRowAt` functions were using spread syntax when assigning the `newValue` const, rather than using the `deepClone` function which is used by all other functions, which resulted in the error.
|
Thank you so much! I'm yarn patching this until it gets merged 🎉 |
|
@mckelveygreg I made a fork that fixes this and some other issues that I'm maintaining for a work project. Should this repo become active again, I'd be more than happy to contribute any patches and updates here instead of maintaining a fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the table within a block editor, having created a table, left the document and returned, adding a new row/s would result in a
Cannot add property x, object is not extensibleerror in the console.Both the
addRowsandaddRowAtfunctions were using spread syntax when assigning thenewValueconst, rather than using thedeepClonefunction which is used by all other functions, resulting in the error.Switching to the
deepClonefunction has resolved this issue.