feat: export Plans page as a component and consume it in apps/admin#1376
Open
paanSinghCoder wants to merge 6 commits intofeat/export-admins-pagefrom
Open
feat: export Plans page as a component and consume it in apps/admin#1376paanSinghCoder wants to merge 6 commits intofeat/export-admins-pagefrom
paanSinghCoder wants to merge 6 commits intofeat/export-admins-pagefrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Pull Request Test Coverage Report for Build 21901150617Details
💛 - Coveralls |
…mproved performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/admintolib/admin/views/plans/usinggit mvwhere applicable to preserve history.PlansViewfrom@raystack/frontier/adminas a router-agnostic view (same behaviour: list plans, client-side table with search/sort/filter, "Plans" header, plan detail in a sheet whenselectedPlanIdis set).PlansPagewrapper inapps/adminthat renders<PlansView selectedPlanId={planId} onCloseDetail={() => navigate("/plans")} />.plansandplans/:planIdroutes to usePlansPage; route paths and behaviour unchanged.Test plan
/plans/:planIdand opens the detail sheet./plans) returns to the list.pnpm buildinweb/lib.pnpm buildinweb/apps/admin.