Skip to content

support websocket connection#730

Open
yahuio wants to merge 6 commits intoquickfixgo:mainfrom
Power-Trade:main
Open

support websocket connection#730
yahuio wants to merge 6 commits intoquickfixgo:mainfrom
Power-Trade:main

Conversation

@yahuio
Copy link

@yahuio yahuio commented Sep 22, 2025

This pull request adds support for connecting to FIX sessions over WebSocket in addition to the existing TCP and proxy-based connections. It introduces new configuration options for WebSocket endpoints, refactors the dialer logic to support multiple connection types, and updates the relevant tests to cover the new functionality. Additionally, some configuration documentation has been clarified, and dependencies in the CI workflow have been updated.

WebSocket Connection Support:

  • Added new configuration options WebsocketLocation and WebsocketOrigin in config/configuration.go for specifying WebSocket endpoints and origins.
  • Implemented WebsocketDialer and refactored the dialer logic in dialer.go to support both TCP and WebSocket connections, with selection based on configuration. [1] [2]
  • Updated the session factory to allow sessions with only WebsocketLocation set (no SocketConnectHost required).

Testing Enhancements:

  • Added tests for WebSocket dialer behavior in dialer_test.go, including handling of missing origins and correct configuration.
  • Added a test for session factory configuration with only WebsocketLocation set in session_factory_test.go.

Codebase Refactoring:

  • Refactored the dialer interface and usage throughout the codebase (e.g., in initiator.go) to use the new Dialer abstraction, removing direct dependency on TCP/proxy dialers. [1] [2] [3] [4]
  • Updated dialer-related tests to work with the new abstraction. [1] [2] [3]

Configuration Documentation:

  • Clarified that SocketConnectHost and SocketConnectPort are only required for initiators using socket connections, not WebSocket. [1] [2]

CI Workflow Maintenance:

  • Updated the MongoDB GitHub Action version in .github/workflows/ci.yaml to 1.12.1 for improved reliability and compatibility. [1] [2]

@yahuio yahuio marked this pull request as ready for review February 17, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants