Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for connecting to FIX sessions over WebSocket in addition to the existing TCP and proxy-based connections. It introduces new configuration options for WebSocket endpoints, refactors the dialer logic to support multiple connection types, and updates the relevant tests to cover the new functionality. Additionally, some configuration documentation has been clarified, and dependencies in the CI workflow have been updated.
WebSocket Connection Support:
WebsocketLocationandWebsocketOrigininconfig/configuration.gofor specifying WebSocket endpoints and origins.WebsocketDialerand refactored the dialer logic indialer.goto support both TCP and WebSocket connections, with selection based on configuration. [1] [2]WebsocketLocationset (noSocketConnectHostrequired).Testing Enhancements:
dialer_test.go, including handling of missing origins and correct configuration.WebsocketLocationset insession_factory_test.go.Codebase Refactoring:
initiator.go) to use the newDialerabstraction, removing direct dependency on TCP/proxy dialers. [1] [2] [3] [4]Configuration Documentation:
SocketConnectHostandSocketConnectPortare only required for initiators using socket connections, not WebSocket. [1] [2]CI Workflow Maintenance:
.github/workflows/ci.yamlto1.12.1for improved reliability and compatibility. [1] [2]