Skip to content

Lower numpy minimum version from 2.3.1 to 1.25.2#84

Merged
ryanhill1 merged 1 commit intomainfrom
loosen-numpy-lower-bound
Mar 10, 2026
Merged

Lower numpy minimum version from 2.3.1 to 1.25.2#84
ryanhill1 merged 1 commit intomainfrom
loosen-numpy-lower-bound

Conversation

@ryanhill1
Copy link
Member

@ryanhill1 ryanhill1 commented Mar 9, 2026

Summary

  • Lowers the numpy lower bound from >=2.3.1 to >=1.25.2
  • The codebase only uses basic numpy APIs (array creation, linalg, FFT, trig) available since ~1.13
  • The practical floor of 1.25.2 is dictated by scipy>=1.16.0's own numpy requirement and Python >=3.11 compatibility

Test plan

  • Verify tests pass with numpy 1.25.2 installed
  • Verify tests pass with latest numpy

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the minimum NumPy version requirement from 2.3.1 to 1.25.2.

The codebase only uses basic numpy APIs available since ~1.13. The
practical lower bound is 1.25.2, dictated by scipy>=1.16.0's own
numpy requirement and Python >=3.11 compatibility.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: cb92dd2b-f036-42f1-8d9e-70e0f387ef8d

📥 Commits

Reviewing files that changed from the base of the PR and between 390b541 and beaf21d.

📒 Files selected for processing (1)
  • requirements.txt

Walkthrough

Modified NumPy minimum version requirement in requirements.txt from >=2.3.1 to >=1.25.2, lowering the baseline version constraint for the NumPy dependency.

Changes

Cohort / File(s) Summary
Dependency Version Management
requirements.txt
Changed NumPy minimum version from 2.3.1 to 1.25.2, expanding compatibility with earlier versions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and concisely describes the main change: lowering the NumPy minimum version requirement from 2.3.1 to 1.25.2, which matches the core change in requirements.txt.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch loosen-numpy-lower-bound

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ryanhill1 ryanhill1 merged commit 8880ec1 into main Mar 10, 2026
8 checks passed
@ryanhill1 ryanhill1 deleted the loosen-numpy-lower-bound branch March 10, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant